Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split up PoS params into sub-keys #3842

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

split up PoS params into sub-keys #3842

wants to merge 2 commits into from
+601 −8

Conversation

tzemanovic
Copy link
Member

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.66370% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.12%. Comparing base (760462b) to head (c21a67d).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
crates/proof_of_stake/src/storage_key.rs 93.54% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3842      +/-   ##
==========================================
+ Coverage   73.01%   73.12%   +0.10%     
==========================================
  Files         340      340              
  Lines      104750   105192     +442     
==========================================
+ Hits        76488    76917     +429     
- Misses      28262    28275      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone added this to the v0.44.0 milestone Sep 24, 2024
@brentstone brentstone marked this pull request as ready for review September 24, 2024 23:33
@tzemanovic
Copy link
Member Author

hermes is updated to use this in https://github.com/heliaxdev/hermes/tree/tomas/namada-3842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentstone brentstone Awaiting requested review from brentstone

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking: protocol
Projects
None yet
Milestone
Future breaking upgrade
Development

Successfully merging this pull request may close these issues.
2 participants
@tzemanovic @brentstone